Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make arg parsing a bit more sane #200

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Make arg parsing a bit more sane #200

merged 2 commits into from
Oct 24, 2024

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Updated arg parsing to behave a touch more sanely and match desired behavior.

⚙️ Test Data and/or Report

harvest --help
Usage: harvest <options>

Commands:
  -c <config file>   Crawl file system and process PDS4 labels
  -V, --version      Print Harvest version

Optional parameters:
  -o <dir>              Output directory (applies to supplemental products only).
                        Default is /tmp/harvest/out
  -l <file>             Log file. Default is /tmp/harvest/harvest.log
  -v <level>            Logger verbosity: DEBUG, INFO (default), WARNING, ERROR
  -O, --overwrite       Overwrite registered products
  -a, --archive-status  Set the archive status for all products defaulting to staged
     archived
     certified
     restricted
     staged

harvest --apple
ERROR] Unrecognized option: --apple

♻️ Related Issues

Closes #199

@al-niessner al-niessner requested a review from a team as a code owner October 17, 2024 23:07
@al-niessner al-niessner self-assigned this Oct 17, 2024
tloubrieu-jpl
tloubrieu-jpl approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will work ok. Thanks @al-niessner

@tloubrieu-jpl tloubrieu-jpl merged commit 5fbe142 into main Oct 24, 2024
3 checks passed
@tloubrieu-jpl tloubrieu-jpl deleted the issue_199 branch October 24, 2024 02:55
@tloubrieu-jpl tloubrieu-jpl changed the title make arg parsing a bit more sane Make arg parsing a bit more sane Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tloubrieu-jpl tloubrieu-jpl tloubrieu-jpl approved these changes

Assignees

@al-niessner al-niessner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user, I want harvest to exit with non 0 code when the arguments are not parsable
2 participants
@al-niessner @tloubrieu-jpl